Cleanup flyte propeller #6516
Cleanup flyte propeller #6516
Conversation
|
Bito Automatic Review Skipped - Draft PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6516 +/- ##
==========================================
+ Coverage 58.58% 58.60% +0.01%
==========================================
Files 929 929
Lines 70851 70832 -19
==========================================
Hits 41510 41510
+ Misses 26194 26176 -18
+ Partials 3147 3146 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sovietaced
force-pushed
the
propeller-cleanup
branch
3 times, most recently
from
990ae01 to
9d6aed8
Compare
|
Bito Automatic Review Skipped - Draft PR |
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
force-pushed
the
propeller-cleanup
branch
from
9d6aed8 to
a7f3de5
Compare
Sovietaced
added
the
housekeeping
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
|
|
||
| w := bufio.NewWriter(f) | ||
|
|
||
| if err != nil { |
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if err != nil { |
| return configSection.GetConfig().(*Config) | ||
| } | ||
|
|
||
| func SetConfig(cfg *Config) error { |
| workflowLauncher launchplan.Executor, launchPlanReader launchplan.Reader, defaultRawOutputPrefix storage.DataReference, kubeClient executors.Client, | ||
| catalogClient catalog.Client, recoveryClient recovery.Client, literalOffloadingConfig config.LiteralOffloadingConfig, eventConfig *config.EventConfig, clusterID string, signalClient service.SignalServiceClient, | ||
| nodeHandlerFactory interfaces.HandlerFactory, scope promutils.Scope) (interfaces.Node, error) { | ||
| func NewExecutor(ctx context.Context, nodeConfig config.NodeConfig, store *storage.DataStore, enQWorkflow v1alpha1.EnqueueWorkflow, eventSink events.EventSink, defaultRawOutputPrefix storage.DataReference, catalogClient catalog.Client, recoveryClient recovery.Client, literalOffloadingConfig config.LiteralOffloadingConfig, eventConfig *config.EventConfig, clusterID string, nodeHandlerFactory interfaces.HandlerFactory, scope promutils.Scope) (interfaces.Node, error) { |
There was a problem hiding this comment.
bunch of unused params here
|
|
||
| // Finalize completes the gate node defined in the NodeExecutionContext | ||
| func (g *gateNodeHandler) Finalize(ctx context.Context, _ interfaces.NodeExecutionContext) error { | ||
| func (g *gateNodeHandler) Finalize(_ context.Context, _ interfaces.NodeExecutionContext) error { |
There was a problem hiding this comment.
| func (g *gateNodeHandler) Finalize(_ context.Context, _ interfaces.NodeExecutionContext) error { | |
| func (g *gateNodeHandler) Finalize(context.Context, interfaces.NodeExecutionContext) error { |
We can also remove _ here?
3 participants
What changes were proposed in this pull request?
Cleans up unused functions, variables, redundant conditions, unused variables, string format issues, redundant type declarations.
How was this patch tested?
Unit tests
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances the Flyte propeller codebase by removing unused functions, variables, and redundant conditions, while addressing string format issues and redundant type declarations. These changes improve code readability and maintainability without altering existing functionality.